Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamav: 1.3.1 -> 1.4.0 #335806

Merged
merged 1 commit into from
Aug 21, 2024
Merged

clamav: 1.3.1 -> 1.4.0 #335806

merged 1 commit into from
Aug 21, 2024

Conversation

martiege
Copy link

@martiege martiege commented Aug 19, 2024

The previous version, 1.3.1, has recently stopped building due to some certifications used in the tests are out of date.

Fixes #334852

Description of changes

Update which version is fetched and the corresponding hash.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@martiege
Copy link
Author

Should fix #334852

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 19, 2024
@martiege
Copy link
Author

Pinging maintainers as well @robberer @qknight @globin

@eclairevoyant eclairevoyant changed the title Update clamav version clamav: 1.3.1 -> 1.4.0 Aug 19, 2024
@eclairevoyant
Copy link
Contributor

Please update commit message to clamav: 1.3.1 -> 1.4.0

@AndersonTorres
Copy link
Member

AndersonTorres commented Aug 19, 2024

Apparently the three are silently retired.

#290642

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge if CI is happy

@cafkafk
Copy link
Member

cafkafk commented Aug 20, 2024

I'll merge if CI is happy

I'm not sure those darwin passthroughs are ever gonna finish...

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Aug 20, 2024
@eclairevoyant eclairevoyant merged commit d26fd47 into NixOS:master Aug 21, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: clamav
7 participants