nixos/dnsmasq: remove deprecated option "extraConfig" #335957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
from
e975116
to
2eccb4b
Compare
KoviRobi
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Makes sense to me, I had a quick look at discourse in case anyone had popped up saying some odd configuration can't be represented, wrt deprecation. Also I can't think of any, given it's just command line flags, and we have a way of repeating command line flags (i.e. lists).
I can't merge, and honestly I'm sadly not very active in the NixOS community/development to give good code review, but LGTM.
fpletz
previously requested changes
Aug 25, 2024
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
from
2eccb4b
to
b9f607b
Compare
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
from
b9f607b
to
d22b374
Compare
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
2 times, most recently
from
fa5b2a2
to
019ab7a
Compare
Scrumplex
approved these changes
Sep 10, 2024
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
from
019ab7a
to
b686e69
Compare
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
2 times, most recently
from
8ec70bc
to
9155fb6
Compare
rhoriguchi
force-pushed
the
nixos/dnsmasq
branch
from
9155fb6
to
bd326c2
Compare
Scrumplex
approved these changes
Sep 20, 2024
bjornfor
approved these changes
Sep 20, 2024
@fpletz: That's done now. |
bjornfor
dismissed
fpletz’s stale review
Release note and mkRemovedOptionModule added now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove deprecated option
nixpkgs/nixos/doc/manual/release-notes/rl-2305.section.md
Lines 417 to 420 in f02fa2f
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.