[Backport release-24.05] kanidm: 1.2.3 -> 1.3.3 #336528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't ofborg fail the same way on master? Cool find! |
|
Yep, I've added it to the master PR too. #336445 |
adamcstephens
force-pushed
the
kanidm/1.3.3-bp
branch
from
eb1c666
to
0212a9b
Compare
https://github.com/kanidm/kanidm/releases/tag/v1.3.0 (cherry picked from commit a29f18d)
(cherry picked from commit 32679fb)
(cherry picked from commit e78f80b)
provision # [ 8.223448] (kanidmd)[819]: kanidm.service: Failed to set up mount namespacing: /ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ofborg-evaluator-1/nixos/tests/common/acme/server: No such file or directory (cherry picked from commit b93f6e4)
adamcstephens
force-pushed
the
kanidm/1.3.3-bp
branch
from
0212a9b
to
00abdbc
Compare
|
The failing cherry pick is expected. Master has a set of changes for provisioning that are not in 24.05. |
|
Looks like this PR broke building kanidm on NixOS 24.05. Updating my system, it now tries to build kanidm from source and fails: Edit: Hydra failed too, but with a timeout: https://hydra.nixos.org/build/270639154 |
|
I built this multiple times to validate it. I kicked off another hydra build to see, but it looks like it maybe timed out or was terminated by hydra and not due to a build failure. When building locally, you will want at least 16GB of memory. |
|
Still building fine for me. |
|
@adamcstephens Timed out again on Hydra. The build itself finishes in one hour but the check phase gets stuck compiling the tests apparently. |
|
Adressed through #338001. |
|
Does anybody else has a crashing service after this? I don't really care, as it was just a dev setup, but I'm wondering wether this poses a bigger problem? Running on NixOS 24.05. |
|
1.3.3 from nixos-24.05 runs fine here. |
|
That looks like an issue with your data. Probably ask upstream if the specific errors aren’t clear enough to allow you to move forward. |
|
Oops, my bad. I upgraded to 1.3.3 and then downgraded to 1.2.3 again. No wonder my installation crashed 🙈 |
Please file an issue for a clearer error message upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade stable to 1.3, as skip upgrades are not permitted. Since upstream currently releases quarterly, we will need to backport releases moving forward.
x86 tests
/nix/store/2nhjvgdccb83y5l788pmnc9w954kfbyv-vm-test-run-kanidm
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.