tmux-fingers: 2.1.1 -> 2.2.2 #336863
Open
tmux-fingers: 2.1.1 -> 2.2.2 #336863
+101
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsierradz
force-pushed
the
update-tmux-fingers
branch
from
4633f78
to
b6e94c3
Compare
|
The binary output LGTM! |
|
Also in the previous PR the reviewer suggested that tests and source code can be removed. |
davidsierradz
force-pushed
the
update-tmux-fingers
branch
from
b6e94c3
to
445d051
Compare
Thanks, done |
Mic92
reviewed
Sep 4, 2024
Mic92
reviewed
Sep 4, 2024
Comment on lines
+29
to
+31
| doCheck = false; | ||
| doInstallCheck = false; |
There was a problem hiding this comment.
Maybe add a comment why tests won't work.
There was a problem hiding this comment.
Thanks, I'm getting the following error with doCheck:
@nix { "action": "setPhase", "phase": "checkPhase" }
Unhandled exception: Missing ENV key: "TMUX" (KeyError)
from /nix/store/1cjf5grfqsjbjvqadsdf8l1nhinj474s-crystal-1.11.2-lib/crystal/env.cr:57:7 in 'fetch'
from /nix/store/1cjf5grfqsjbjvqadsdf8l1nhinj474s-crystal-1.11.2-lib/crystal/env.cr:22:5 in '[]'
from src/fingers/dirs.cr:5:15 in '~Fingers::Dirs::TMUX_PID:init'
from src/fingers/dirs.cr:6:3 in '__crystal_main'
from /nix/store/1cjf5grfqsjbjvqadsdf8l1nhinj474s-crystal-1.11.2-lib/crystal/crystal/main.cr:129:5 in 'main_user_code'
from /nix/store/1cjf5grfqsjbjvqadsdf8l1nhinj474s-crystal-1.11.2-lib/crystal/crystal/main.cr:115:7 in 'main'
from /nix/store/1cjf5grfqsjbjvqadsdf8l1nhinj474s-crystal-1.11.2-lib/crystal/crystal/main.cr:141:3 in 'main'
from /nix/store/wlffq5p6mxxgfap10sav3ij936jzqm59-glibc-2.39-52/lib/libc.so.6 in '??'
from /nix/store/wlffq5p6mxxgfap10sav3ij936jzqm59-glibc-2.39-52/lib/libc.so.6 in '__libc_start_main'
from /build/source/.crystal/crystal-run-spec.tmp in '_start'
from ???
445d051
to
892012a
Compare
davidsierradz
force-pushed
the
update-tmux-fingers
branch
from
892012a
to
09abf10
Compare
davidsierradz
force-pushed
the
update-tmux-fingers
branch
from
09abf10
to
c9c7974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
First time writing a Crystal derivation, let me know any changes or improvements I should do!
Friendly ping: @Mic92 @WilliamHsieh
tmux-fingers/CHANGELOG.md at master · Morantron/tmux-fingers
From use cling shard to handle arg parsing · Morantron/tmux-fingers@97d1ddd,
tmux-fingersneed shards to build.Things done
crystal2nixto generateshards.nixfingersbinaryI mostly copied the build pattern from nixpkgs/pkgs/misc/tmux-plugins/tmux-thumbs/default.nix at master · NixOS/nixpkgs
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.