-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rathole: 0.5.0 -> 0.5.0-unstable-2024-06-06 #337095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this into multiple commits.
9f3136e
to
cdb86bd
Compare
@ofborg eval |
cdb86bd
to
80bd447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future when fixing a broken package, it'd be better to focus on just fixing the breakage, as it takes longer to find the time to review and merge a PR that makes a lot of changes.
pkgs/by-name/ra/rathole/package.nix
Outdated
@@ -30,18 +30,20 @@ rustPlatform.buildRustPackage rec { | |||
|
|||
__darwinAllowLocalNetworking = true; | |||
|
|||
doCheck = false; # https://github.com/rapiz1/rathole/issues/222 | |||
doCheck = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default.
- Update to [be14d12](rapiz1/rathole@be14d12), which has Rust 1.80 fixes - Re-enable doCheck - Add myself as maintainer - Sort meta attributes - Remove with lib; usage - Drop changelog for unstable version, since upstream does not track unreleased changes
80bd447
to
7fcb06a
Compare
Hi, may I know can you all merge it? |
Description of changes
Fixes build failure introduced with Rust 1.80. See tracking issue: #332957.
The necessary time crate bump is already in main: rapiz1/rathole#380
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.