Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qidi-slicer-bin: init at 1.1.7 #337224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Aug 25, 2024

Description of changes

Package QIDISlicer, a fork of PrusaSlicer for QIDI 3D Printers.

Currently uses an AppImage from upstream release, hence the -bin suffix. Relevant to #336869 until I can get a more powerful build host to build from source.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 25, 2024
@j0hax j0hax force-pushed the qidislicer-bin branch 2 times, most recently from 343184d to b196a64 Compare August 25, 2024 12:40
pkgs/by-name/qi/qidi-slicer-bin/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qi/qidi-slicer-bin/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qi/qidi-slicer-bin/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qi/qidi-slicer-bin/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qi/qidi-slicer-bin/package.nix Outdated Show resolved Hide resolved
@j0hax
Copy link
Member Author

j0hax commented Aug 25, 2024

Thanks for taking the time to review 😃

@j0hax j0hax self-assigned this Aug 29, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 31, 2024
@j0hax j0hax changed the title qidi-slicer-bin: init at 1.1.5 qidi-slicer-bin: init at 1.1.7 Nov 12, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants