-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.05] morgen: electron_29 -> electron_30 #337320
Conversation
Result of 1 package built:
|
@justanotherariel Do you know if 3.4.2 will work with Electron 30 or if we need to backport the 3.5.5 update as well? |
Hm, I can't test it because it complains that I'm downgrading - I would need to remove all related files first and I don't want to break things on my machine. I'd say, it's likely that it will still work, but since there are no breaking changes (just added features and performance improvements) in morgen version 3.5.5, probably just upgrade? Just to be on the safe side. |
0cb37a9
to
fdd1865
Compare
@justanotherariel I’ve backported the bumps – please take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes
Manual backport of #336026.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.