Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] simplex-chat-desktop: 5.8.1 -> 6.0.3 #337536

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

TerryGarcia
Copy link
Contributor

(cherry picked from commit a852d3d)

Description of changes

Manual backport of #325443


Add a 👍 reaction to pull requests you find important.

@TerryGarcia
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@TerryGarcia merge not permitted (#305350):
pr is not targeted to any of the allowed branches: staging, staging-next, master

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice that according to contributing.md

The release branches should generally only receive backwards-compatible changes, both for the Nix expressions and derivations.
Here are some examples of backwards-compatible changes that are okay to backport:
- ✔️ New packages, modules and functions
- ✔️ Security fixes
- ✔️ Package version updates
  - ✔️ Patch versions with fixes
  - ✔️ Minor versions with new functionality, but no breaking changes

In addition, major package version updates with breaking changes are also acceptable for:
- ✔️ Services that would fail without up-to-date client software, such as `spotify`, `steam`, and `discord`
- ✔️ Security critical applications, such as `firefox` and `chromium`

This is a major version change, and doesn't obviously seem to be required, as the current version in stable builds fine.

Also do note that the download page https://simplex.chat/downloads/ says that "The latest stable version is v5.8.`, but I'm pretty sure that is just outdated, they do seem to follow semver on their github repo.

Maybe this doesn't break anything and it's fine, even if it's a major version, and perhaps since it's a privacy chat tool, being up to date makes it a "security critical application".

Do you know if this introduced any breaking changes? (I don't know program this well enough to tell)

@TerryGarcia
Copy link
Contributor Author

I use the program a lot on my computer and have upgraded to 6.0.3, and I haven't noticed any breaking changes.

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think that's sufficient enough for backporting, LGTM, thanks for taking up maintainership of this!

(passthrough tests that haven't finished running are on unsupported targets, and this package doesn't have any passthrough tests, so doesn't seem like that should be a problematic to ignore)

@cafkafk cafkafk merged commit bcb8ab6 into NixOS:release-24.05 Aug 27, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants