mkPythonMetaPackage: init meta package function (and psycopg2-binary) #337621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
psycopg2-binary
branch
from
8635489
to
0c2bdf9
Compare
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
adisbladis
force-pushed
the
psycopg2-binary
branch
from
0c2bdf9
to
9382b96
Compare
jian-lin
reviewed
Aug 27, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages.nix
Outdated
Show resolved
Hide resolved
adisbladis
force-pushed
the
psycopg2-binary
branch
from
9382b96
to
e2959d2
Compare
misuzu
approved these changes
Aug 27, 2024
dotlambda
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Very nice!
I wonder if it would make sense to turn this into a function to produce such a package that could also be used for e.g. https://pypi.org/project/phonenumberslite/
adisbladis
force-pushed
the
psycopg2-binary
branch
from
e2959d2
to
472b732
Compare
Good idea! I've added a |
adisbladis
changed the title
adisbladis
force-pushed
the
psycopg2-binary
branch
from
472b732
to
226544e
Compare
This function exists create a meta package containing [metadata files](https://packaging.python.org/en/latest/specifications/recording-installed-packages/) to satisfy a dependency on a package, without it actually having been installed into the environment.
adisbladis
force-pushed
the
psycopg2-binary
branch
from
226544e
to
f3aee82
Compare
dotlambda
reviewed
Aug 29, 2024
Pscycopg2-binary is normally used in Python development to avoid having to build psycopg2 from source. In nixpkgs we always want ot build from source whenever possible, but it can still be useful to provide a psycopg2-binary package. This "fake" package exists to satisfy a dependency on psycopg2-binary, but still use the build from psycopg2. cc @misuzu nix-community/pyproject.nix#143
adisbladis
force-pushed
the
psycopg2-binary
branch
from
f3aee82
to
d3e7844
Compare
13 tasks
adisbladis
added a commit
to adisbladis/nixpkgs
that referenced
this pull request
Aug 30, 2024
In NixOS#337621 I had initially created an empty, but importable package, meaning that initial tests worked just fine, because the top_level.txt file is always created when an importable package exists. Subsequent refactors removed the importable package, but didn't verify that the dependency satisfaction still works, only that the metadata output looked good. It was a bit tricky to express what I wanted to with hatchling, so I switched to setuptools.
adisbladis
added a commit
to adisbladis/nixpkgs
that referenced
this pull request
Aug 30, 2024
In NixOS#337621 I had initially created an empty, but importable package, meaning that initial tests worked just fine. Subsequent refactors removed the importable package, but didn't verify that the dependency satisfaction still works, only that the metadata output looked good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a function
mkPythonMetaPackagethat exists to satisfy a dependency on a package, but don't actually build it.This is useful for packages that have a split binary/source dichotomy like psycopg2/psycopg2-binary, where we want to use the former, but some projects declare a dependency on the latter.
This PR:
mkPythonMetaPackagefunctionpsycopg2-binarythat uses itOverride hacks could be dropped from:
cc @misuzu nix-community/pyproject.nix#143
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.