-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpt4all: 2.8.0 -> 3.2.1 #337747
gpt4all: 2.8.0 -> 3.2.1 #337747
Conversation
I've tested functionality locally on nixOS w/o any issues! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title should be: gpt4all: 2.8.0 -> 3.2.1
42fc699
to
b21f121
Compare
@ryand56 fixed. lol. ty for pointing that out :) |
@ryand56 does it all look good to you now? |
Looks good :) I'll test it later |
When I apply this patch and build on x86_64-linux, I end up with a file named More specifically - no embeddings for local docs are being generated; and the console has the following error:
|
Here's what ended up working for me, in case it helps: e56a0c7 |
@reedriley thanks for the feedback! I'll apply your changes tomorrow. Good catch! |
b21f121
to
75db703
Compare
@reedriley just pushed your changes, ty <3 |
75db703
to
a1ac9dc
Compare
LGTM! |
@polygon any thoughts? the bot added you to review this :p |
Looks like @drupol pulled a nice bait and switch on me. I maintained this out-of-tree because I only sporadically find time for maintenance work. Then he pushed for adoption into Nixpkgs and removed himself as a maintainer shortly after. I will look into this, but it can take some time. If anyone wants to co-maintain this package, feel free to take over. |
@polygon Sorry mate, it's not intentional at all... I try to avoid maintaining stuff I don't use, or else it's too much work for me. Regarding this GPT4All, I used to use it until I switched to |
I can work on it more if needed :) I want some more nix experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be:
-gpt4all 2.8.0 -> 3.2.1
+gpt4all: 2.8.0 -> 3.2.1
@Titaniumtown if you wanna help maintain this package, you can also add yourself to the maitnainer-list.nix
& meta.maintainers
of this package.
a1ac9dc
to
b01f615
Compare
@felschr I've added myself now! Thank you :) |
@Titaniumtown adding yourself to the maintainers list & to |
oh so sorry. I'll fix that right now. |
Also as you can see in the checks, |
b01f615
to
abcf146
Compare
Result of 2 packages built:
|
@Titaniumtown thank you for the update and welcome as a package maintainer 🥳! |
Thank you so much @felschr! I'm excited! |
Description of changes
Changelog
closes: #335993
Things done
Updated gpt4all and added a patch to disable compile-time fetching of an embeddings model, shifted that to be done directly in the nix package.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.