Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide/nixos: remove with lib; part 6 #337780

Draft
wants to merge 153 commits into
base: master
Choose a base branch
from
Draft

treewide/nixos: remove with lib; part 6 #337780

wants to merge 153 commits into from

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

part of #208242

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 27, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-6 branch from db6e797 to 3d22935 Compare August 27, 2024 20:36
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-6 branch 6 times, most recently from 783f722 to b347d5a Compare August 27, 2024 22:12
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 27, 2024
@Stunkymonkey Stunkymonkey force-pushed the treewide-nixos-remove-with-lib-6 branch 2 times, most recently from 0c4511e to 411d02b Compare August 28, 2024 21:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Aug 28, 2024
@philiptaron philiptaron self-requested a review September 3, 2024 16:15
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@Stunkymonkey
nixos/modules/installer/netboot/netboot-base.nix: remove with lib;
735eaa5
@Stunkymonkey
nixos/modules/installer/netboot/netboot.nix: remove with lib;
b558874
@Stunkymonkey
nixos/modules/profiles/headless.nix: remove with lib;
d130409
@Stunkymonkey
nixos/modules/profiles/installation-device.nix: remove with lib;
561b36d
@Stunkymonkey
nixos/modules/security/rtkit.nix: remove with lib;
5c884d2
@Stunkymonkey
nixos/modules/services/cluster/kubernetes/kubelet.nix: remove `with l…
13ef2a0 
…ib;`
@Stunkymonkey
nixos/modules/services/cluster/kubernetes/pki.nix: remove with lib;
16f1ab5
@Stunkymonkey
nixos/modules/services/cluster/kubernetes/proxy.nix: remove with lib;
6b6ff08
@Stunkymonkey
nixos/modules/services/continuous-integration/gocd-server/default.nix…
a2d6fe1 
…: remove `with lib;`
@Stunkymonkey
nixos/modules/services/networking/icecream/daemon.nix: remove `with l…
1f050d4 
…ib;`
@Stunkymonkey
nixos/modules/services/networking/icecream/scheduler.nix: remove `wit…
85d04bb 
…h lib;`
@Stunkymonkey
nixos/modules/services/networking/ircd-hybrid/default.nix: remove `wi…
87f9e2b 
…th lib;`
@Stunkymonkey
nixos/modules/services/web-apps/flarum.nix: remove with lib;
76b4a25
@Stunkymonkey
nixos/modules/services/web-apps/fluidd.nix: remove with lib;
a1c636c
@Stunkymonkey
nixos/modules/services/web-apps/freshrss.nix: remove with lib;
c25e458
@Stunkymonkey
nixos/modules/services/web-apps/galene.nix: remove with lib;
958b605
@Stunkymonkey
nixos/modules/services/web-apps/gerrit.nix: remove with lib;
aefd98d
@Stunkymonkey
nixos/modules/services/web-apps/grocy.nix: remove with lib;
ed7e2c5
@Stunkymonkey
nixos/modules/services/web-apps/healthchecks.nix: remove with lib;
6ae942c
@Stunkymonkey
nixos/modules/services/web-apps/hledger-web.nix: remove with lib;
00324ca
@Stunkymonkey
nixos/modules/services/web-apps/invoiceplane.nix: remove with lib;
02096fa
@Stunkymonkey
nixos/modules/services/web-apps/jirafeau.nix: remove with lib;
b79f669
@Stunkymonkey
nixos/modules/services/web-apps/jitsi-meet.nix: remove with lib;
c50074a
@Stunkymonkey
nixos/modules/services/web-apps/lemmy.nix: remove with lib;
01a0bc6
@Stunkymonkey
nixos/modules/services/x11/window-managers/jwm.nix: remove with lib;
20fea76
@Stunkymonkey
nixos/modules/services/x11/window-managers/tinywm.nix: remove `with l…
3d3eafc 
…ib;`
@Stunkymonkey
nixos/modules/services/x11/window-managers/twm.nix: remove with lib;
4f65efd
@Stunkymonkey
nixos/modules/services/x11/window-managers/wmderland.nix: remove `wit…
d91e74b 
…h lib;`
@Stunkymonkey
nixos/modules/services/x11/window-managers/wmii.nix: remove with lib;
ce70f8a
@Stunkymonkey
nixos/modules/services/x11/xfs.nix: remove with lib;
e9b5a82
@Stunkymonkey
nixos/modules/system/activation/activation-script.nix: remove `with l…
765c9f7 
…ib;`
@Stunkymonkey
nixos/modules/system/activation/no-clone.nix: remove with lib;
0e27461
@Stunkymonkey
nixos/modules/system/activation/top-level.nix: remove with lib;
585d170
@Stunkymonkey
nixos/modules/system/boot/loader/init-script/init-script.nix: remove …
edf36c3 
…`with lib;`
@Stunkymonkey
nixos/modules/system/boot/loader/raspberrypi/raspberrypi.nix: remove …
8744f9a 
…`with lib;`
@Stunkymonkey
nixos/modules/tasks/filesystems/exfat.nix: remove with lib;
b5150fb
@Stunkymonkey
nixos/modules/tasks/filesystems/vboxsf.nix: remove with lib;
55b24d2
@Stunkymonkey
nixos/modules/tasks/filesystems/vfat.nix: remove with lib;
1489249
@Stunkymonkey
nixos/modules/tasks/filesystems/xfs.nix: remove with lib;
7c55569
@Stunkymonkey
nixos/modules/tasks/trackpoint.nix: remove with lib;
c2f60b2
@Stunkymonkey
nixos/modules/virtualisation/digital-ocean-init.nix: remove with lib;
3b37d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @wegank