Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] obsidian: backports #337794

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Aug 27, 2024

Description of changes

See #337776.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

w-lfchen and others added 8 commits August 27, 2024 21:32
(cherry picked from commit 1f577fc)
(cherry picked from commit 2265a2f)
(cherry picked from commit ead69bb)
(cherry picked from commit bac1a06)
(cherry picked from commit a8c8ce9)
(cherry picked from commit 09e0083)
(cherry picked from commit 1335aed)
@w-lfchen
Copy link
Member

Result of nixpkgs-review pr 337794 run on x86_64-linux 1

1 package built:
  • obsidian

Copy link
Member

@w-lfchen w-lfchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my first time working with backports, but if everything builds and works here there should be no issues, right?

also, thank you for your work <3

@emilazy
Copy link
Member Author

emilazy commented Aug 28, 2024

Yep, building and running is exactly the goal here :)

Thanks for checking!

@emilazy emilazy merged commit ee3f4c3 into NixOS:release-24.05 Aug 28, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants