Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfcgal: init at 1.5.2 #338058

Merged
merged 1 commit into from
Sep 6, 2024
Merged

sfcgal: init at 1.5.2 #338058

merged 1 commit into from
Sep 6, 2024

Conversation

fqidz
Copy link
Contributor

@fqidz fqidz commented Aug 28, 2024

Description of changes

https://sfcgal.gitlab.io/SFCGAL/

SFCGAL is a C++ wrapper library around CGAL with the aim of supporting ISO 19107:2013 and OGC Simple Features Access 1.2 for 3D operations.

my first ever pull request 🎉

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 28, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 28, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Aug 29, 2024
@moni-dz
Copy link
Contributor

moni-dz commented Aug 30, 2024

@ofborg build SFCGAL

pkgs/by-name/sf/SFCGAL/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sf/SFCGAL/package.nix Outdated Show resolved Hide resolved
@fqidz fqidz force-pushed the sfcgal-library branch 3 times, most recently from 8d07d0f to b958f3c Compare September 2, 2024 17:10
@fqidz fqidz marked this pull request as draft September 2, 2024 17:12
@fqidz fqidz marked this pull request as ready for review September 2, 2024 17:35
pkgs/by-name/sf/sfcgal/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sf/sfcgal/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sf/sfcgal/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sf/sfcgal/package.nix Outdated Show resolved Hide resolved
@fqidz fqidz force-pushed the sfcgal-library branch 3 times, most recently from d4349e6 to e347e99 Compare September 4, 2024 15:05
@Aleksanaa Aleksanaa merged commit 00c2219 into NixOS:master Sep 6, 2024
26 of 27 checks passed
@fqidz fqidz deleted the sfcgal-library branch September 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants