Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.jaxlib-bin: update gpuSrcs keys to 12.4 #338199

Closed
wants to merge 1 commit into from

Conversation

GaetanLepage
Copy link
Contributor

Description of changes

When running nixpkgs-review targetting a darwin architecture (on some indirectly related PRs), I get:

at /home/gaetan/.cache/nixpkgs-review/pr-338197-5/nixpkgs/pkgs/development/python-modules/jaxlib/bin.nix:184:7:

  183|     else
  184|       gpuSrcs."${gpuSrcVersionString}";
     |       ^
  185|
Did you mean one of cuda12.2-3.11, cuda12.2-3.10 or cuda12.2-3.12?

cc @SomeoneSerge @danieldk

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Probably caused by recently merged #335749

@GaetanLepage
Copy link
Contributor Author

This solution does not work. I still get the same error when running nixpkgs-review on this PR (only for darwin).

@SomeoneSerge
Copy link
Contributor

Why can't we just delete all binaryNativeCode packages...

@GaetanLepage
Copy link
Contributor Author

Why can't we just delete all binaryNativeCode packages...

As soon as we get recent tensorflow versisons to build...

Comment on lines +158 to 160
"cuda12.4-3.12" = fetchurl {
url = "https://storage.googleapis.com/jax-releases/cuda12/jaxlib-${version}+cuda12.cudnn89-cp312-cp312-manylinux2014_x86_64.whl";
hash = "sha256-ixWMaIChy4Ammsn23/3cCoala0lFibuUxyUr3tjfFKU=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the url but not the hash?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no I'm wrong

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 29, 2024
@GaetanLepage
Copy link
Contributor Author

I cannot reproduce the bug consistently.
Anyway, I don't think that my fix is relevant at all. Closing.

@GaetanLepage GaetanLepage deleted the jaxlib-bin branch August 30, 2024 06:08
@SomeoneSerge
Copy link
Contributor

Odd. We still don't know what the missing key was. FWIW we could replace they attrset look-up with a function that returns a trace or a throw when the key is missing. Wouldn't matter for ofborg as long as all expected branches have the corresponding keys as they should

@Artturin
Copy link
Member

Artturin commented Sep 5, 2024

Odd. We still don't know what the missing key was. FWIW we could replace they attrset look-up with a function that returns a trace or a throw when the key is missing. Wouldn't matter for ofborg as long as all expected branches have the corresponding keys as they should

#339879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants