-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weblate: address additional review on package and dependencies #338217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't remove borgbackup from dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erictapen Thanks for following up on the review notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of meta changes :)
pkgs/development/python-modules/django-crispy-bootstrap5/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-crispy-bootstrap4/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/django-crispy-bootstrap3/default.nix
Outdated
Show resolved
Hide resolved
I went through and double-checked all the licenses introduced by #325541 and #334849:
I actually had to fix the license for Weblate vendors in a few dependencies with licenses such as As laid out in #338217 (comment), I'd leave CC0 licenses in files like
|
…system, sort dependencies
some files are actually licensed by MIT
Description of changes
Addresses @dotlambda s reviews in #325541 (comment) and #334849 (review).
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.