Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.aeidon: modernize #338224

Merged
merged 1 commit into from
Aug 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 19 additions & 28 deletions pkgs/development/python-modules/aeidon/default.nix
Original file line number Diff line number Diff line change
@@ -1,46 +1,36 @@
{
lib,
buildPythonPackage,
fetchPypi,
gettext,
flake8,
isocodes,
fetchFromGitHub,
setuptools,
pytestCheckHook,
charset-normalizer,
}:

buildPythonPackage rec {
pname = "aeidon";
version = "1.15";
pyproject = true;

src = fetchPypi {
pname = "aeidon";
inherit version;
sha256 = "sha256-qGpGraRZFVaW1Jys24qvfPo5WDg7Q/fhvm44JH8ulVw=";
src = fetchFromGitHub {
owner = "otsaloma";
repo = "gaupol";
rev = "refs/tags/${version}";
hash = "sha256-lhNyeieeiBBm3rNDEU0BuWKeM6XYlOtv1voW8tR8cUM=";
};

nativeBuildInputs = [
gettext
flake8
];

dependencies = [ isocodes ];

installPhase = ''
runHook preInstall
python setup.py --without-gaupol install --prefix=$out
runHook postInstall
postPatch = ''
mv setup.py setup_gaupol.py
substituteInPlace setup-aeidon.py \
--replace "from setup import" "from setup_gaupol import"
mv setup-aeidon.py setup.py
'';

nativeCheckInputs = [
pytestCheckHook
charset-normalizer
];
build-system = [ setuptools ];

# Aeidon is looking in the wrong subdirectory for data
preCheck = ''
cp -r data aeidon/
'';
dependencies = [ charset-normalizer ];

nativeCheckInputs = [ pytestCheckHook ];

pytestFlagsArray = [ "aeidon/test" ];

Expand All @@ -52,9 +42,10 @@ buildPythonPackage rec {
pythonImportsCheck = [ "aeidon" ];

meta = with lib; {
changelog = "https://github.com/otsaloma/gaupol/releases/tag/${version}";
description = "Reading, writing and manipulationg text-based subtitle files";
homepage = "https://github.com/otsaloma/gaupol";
license = licenses.gpl3Only;
license = licenses.gpl3Plus;
erictapen marked this conversation as resolved.
Show resolved Hide resolved
maintainers = with maintainers; [ erictapen ];
};

Expand Down