Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repak: init at 0.2.2 #338242

Merged
merged 2 commits into from
Oct 29, 2024
Merged

repak: init at 0.2.2 #338242

merged 2 commits into from
Oct 29, 2024

Conversation

florensie
Copy link
Contributor

Description of changes

https://github.com/trumank/repak

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 29, 2024
AndersonTorres
AndersonTorres reviewed Aug 30, 2024
View reviewed changes
pkgs/by-name/re/repak/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/repak/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/repak/package.nix Outdated Show resolved Hide resolved
Bot-wxt1221
Bot-wxt1221 approved these changes Sep 3, 2024
View reviewed changes
pkgs/by-name/re/repak/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 4, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 6, 2024
Bot-wxt1221
Bot-wxt1221 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 7, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 8, 2024
@Aleksanaa Aleksanaa merged commit 90e4a83 into NixOS:master Oct 29, 2024
28 of 29 checks passed
@florensie florensie deleted the init-repak branch October 29, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@florensie @AndersonTorres @Bot-wxt1221 @wegank @Aleksanaa