Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fleeting-plugin-aws: init at 1.0.0 #338276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

commiterate
Copy link
Contributor

Description of changes

Initialize fleeting-plugin-aws at 1.0.0.

Fleeting is used for auto-scaling GitLab runners in cloud providers (e.g. AWS, Google Cloud, Azure).

The runner manager/autoscaler needs to have GitLab Runner and the appropriate fleeting plugin installed. GitLab Runner can discover fleeting plugins as long as they're on PATH.

For NixOS users, this probably means a NixOS configuration like this:

configuration.nix

{
  config,
  pkgs,
  ...
}:

{
  # ...

  # If you run GitLab Runner as a systemd unit.
  services = {
    gitlab-runner = {
      enable = true;
      extraPackages = with pkgs; [ fleeting-plugin-aws ];

      # ...
    };
  };

  # If you run GitLab Runner via the CLI. This or a user-specific package list with Home Manager.
  environment = {
    systemPackages = with pkgs; [
      gitlab-runner
      fleeting-plugin-aws
    ];
  };

  # ...
}

Tested the binary to ensure the Go variable flags used for the fleeting-plugin-aws version command works correctly.

% nix-build -A fleeting-plugin-aws
/nix/store/2hb3yyq8mr4qik4r9gclppgfp3qqac7b-fleeting-plugin-aws-1.0.0

% tree /nix/store/2hb3yyq8mr4qik4r9gclppgfp3qqac7b-fleeting-plugin-aws-1.0.0
/nix/store/2hb3yyq8mr4qik4r9gclppgfp3qqac7b-fleeting-plugin-aws-1.0.0
└── bin
    └── fleeting-plugin-aws

% /nix/store/2hb3yyq8mr4qik4r9gclppgfp3qqac7b-fleeting-plugin-aws-1.0.0/bin/fleeting-plugin-aws version
Name:         fleeting-plugin-aws
Version:      v1.0.0
Git revision: refs/tags/v1.0.0
Git ref:      HEAD
GO version:   go1.22.5
Built:        now
OS/Arch:      darwin/arm64

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Comment on lines +53 to +57
# TODO: Find maintainer(s).
maintainers = with lib.maintainers; [ ];
Copy link
Contributor Author

@commiterate commiterate Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably won't be a reliable maintainer, so leaving out a maintainers list for now.

Would the GitLab maintainers team be interested in this? (cc: @globin @krav @talyz @yayayayaka)

I'll probably be adding GitLab's Nesting as well since this work is in preparation for a GitLab Runner fleet on AWS Mac metal instances with nested virtualization (example).

I can also create packages for the other Fleeting plugins (Google Cloud and Azure).

Copy link
Contributor Author

@commiterate commiterate Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nesting PR: #338281

Blocked on the apple_sdk refactor.

This PR can be merged once we find a maintainer though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants