librewolf-bin: init at 129.0.2.1 #338466
Merged
librewolf-bin: init at 129.0.2.1 #338466
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclairevoyant
force-pushed
the
librewolf-bin
branch
from
409c904
to
92ac112
Compare
eclairevoyant
force-pushed
the
librewolf-bin
branch
from
92ac112
to
6d3fa00
Compare
|
I've tested basic things like running the browser, opening files, checking that the menus and default settings look like they match what's expected - but would appreciate any feedback if there's something missing here. |
ofborg
bot
added
8.has: package (new)
squalus
approved these changes
Aug 30, 2024
|
Looks good. I tested it on NixOS x86_64-linux and it works as expected. |
eclairevoyant
added
the
12.approvals: 1
fpletz
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds librewolf as packaged by upstream via their AppImage.
Mitigates issues such as #338439 that can arise due to packaging differences, and ensures that users have a browser that's as identical to the upstream intent as possible (to minimise the possibility of data privacy leakage).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.