-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color transformation language init #338697
base: master
Are you sure you want to change the base?
Color transformation language init #338697
Conversation
17d998a
to
985e8ca
Compare
0ac0b64
to
f072933
Compare
@eclairevoyant I don't understand what I'm supposed to do with that check failure. |
|
@eclairevoyant so I just don't need to reference the packages at all in |
The whole point of |
f072933
to
642f042
Compare
@ofborg build art |
642f042
to
4539588
Compare
@eclairevoyant I made the git history a lot cleaner and I've made all requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the finalAttrs
pattern instead of the rec
keyword.
stdenv.mkDerivation rec { | ||
pname = "aces-container"; | ||
version = "1.0.2"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "ampas"; | ||
repo = "aces_container"; | ||
rev = "v${version}"; | ||
hash = "sha256-luMqXqlJ6UzoawEDmbK38lm3GHosaZm/mFJntBF54Y4="; | ||
}; | ||
|
||
nativeBuildInputs = [ | ||
cmake | ||
]; | ||
|
||
meta = { | ||
description = "Reference Implementation of SMPTE ST2065-4"; | ||
homepage = "https://github.com/ampas/aces_container"; | ||
license = lib.licenses.ampas; | ||
maintainers = with lib.maintainers; [ paperdigits ]; | ||
mainProgram = "aces-container"; | ||
platforms = lib.platforms.all; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.mkDerivation rec { | |
pname = "aces-container"; | |
version = "1.0.2"; | |
src = fetchFromGitHub { | |
owner = "ampas"; | |
repo = "aces_container"; | |
rev = "v${version}"; | |
hash = "sha256-luMqXqlJ6UzoawEDmbK38lm3GHosaZm/mFJntBF54Y4="; | |
}; | |
nativeBuildInputs = [ | |
cmake | |
]; | |
meta = { | |
description = "Reference Implementation of SMPTE ST2065-4"; | |
homepage = "https://github.com/ampas/aces_container"; | |
license = lib.licenses.ampas; | |
maintainers = with lib.maintainers; [ paperdigits ]; | |
mainProgram = "aces-container"; | |
platforms = lib.platforms.all; | |
}; | |
} | |
stdenv.mkDerivation (finalAttrs: { | |
pname = "aces-container"; | |
version = "1.0.2"; | |
src = fetchFromGitHub { | |
owner = "ampas"; | |
repo = "aces_container"; | |
rev = "v${finalAttrs.version}"; | |
hash = "sha256-luMqXqlJ6UzoawEDmbK38lm3GHosaZm/mFJntBF54Y4="; | |
}; | |
nativeBuildInputs = [ | |
cmake | |
]; | |
meta = { | |
description = "Reference Implementation of SMPTE ST2065-4"; | |
homepage = "https://github.com/ampas/aces_container"; | |
license = lib.licenses.ampas; | |
maintainers = with lib.maintainers; [ paperdigits ]; | |
mainProgram = "aces-container"; | |
platforms = lib.platforms.all; | |
}; | |
}) |
stdenv.mkDerivation rec { | ||
pname = "ctl"; | ||
version = "1.5.3"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "ampas"; | ||
repo = "CTL"; | ||
rev = "ctl-${version}"; | ||
hash = "sha256-jG+38jsPw+4CEAbOG+hudfPBPbZLG+Om7PszkFa6DuI="; | ||
}; | ||
|
||
nativeBuildInputs = [ | ||
cmake | ||
ilmbase | ||
openexr_3 | ||
libtiff | ||
aces-container | ||
]; | ||
|
||
meta = { | ||
description = "Programming language for digital color management"; | ||
homepage = "https://github.com/ampas/CTL"; | ||
changelog = "https://github.com/ampas/CTL/blob/${src.rev}/CHANGELOG"; | ||
license = lib.licenses.ampas; | ||
maintainers = with lib.maintainers; [ paperdigits ]; | ||
mainProgram = "ctl"; | ||
platforms = lib.platforms.all; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdenv.mkDerivation rec { | |
pname = "ctl"; | |
version = "1.5.3"; | |
src = fetchFromGitHub { | |
owner = "ampas"; | |
repo = "CTL"; | |
rev = "ctl-${version}"; | |
hash = "sha256-jG+38jsPw+4CEAbOG+hudfPBPbZLG+Om7PszkFa6DuI="; | |
}; | |
nativeBuildInputs = [ | |
cmake | |
ilmbase | |
openexr_3 | |
libtiff | |
aces-container | |
]; | |
meta = { | |
description = "Programming language for digital color management"; | |
homepage = "https://github.com/ampas/CTL"; | |
changelog = "https://github.com/ampas/CTL/blob/${src.rev}/CHANGELOG"; | |
license = lib.licenses.ampas; | |
maintainers = with lib.maintainers; [ paperdigits ]; | |
mainProgram = "ctl"; | |
platforms = lib.platforms.all; | |
}; | |
} | |
stdenv.mkDerivation (finalAttrs: { | |
pname = "ctl"; | |
version = "1.5.3"; | |
src = fetchFromGitHub { | |
owner = "ampas"; | |
repo = "CTL"; | |
rev = "ctl-${finalAttrs.version}"; | |
hash = "sha256-jG+38jsPw+4CEAbOG+hudfPBPbZLG+Om7PszkFa6DuI="; | |
}; | |
nativeBuildInputs = [ | |
cmake | |
ilmbase | |
openexr_3 | |
libtiff | |
aces-container | |
]; | |
meta = { | |
description = "Programming language for digital color management"; | |
homepage = "https://github.com/ampas/CTL"; | |
changelog = "https://github.com/ampas/CTL/blob/${src.rev}/CHANGELOG"; | |
license = lib.licenses.ampas; | |
maintainers = with lib.maintainers; [ paperdigits ]; | |
mainProgram = "ctl"; | |
platforms = lib.platforms.all; | |
}; | |
}) |
Description of changes
Add CTL capability to ART. This involved packaging CTL (color-transform-language) and aces-container.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.