Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn-rs: init at 3.1.0 #338928

Merged
merged 2 commits into from
Sep 19, 2024
Merged

turn-rs: init at 3.1.0 #338928

merged 2 commits into from
Sep 19, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Sep 2, 2024 •
edited
Loading

Description of changes

turn-rs: init at 3.0.0

Fix #338638

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 2, 2024
@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Sep 2, 2024
Closed
@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Sep 2, 2024 •
edited
Loading

Upstream has already added Cargo.lock to main. Wait for next release. So make it draft.

@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft September 2, 2024 12:57
@nyabinary
Copy link
Contributor

Shouldn't a module be added as well?

@Bot-wxt1221 Bot-wxt1221 added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Sep 6, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 11, 2024
@Bot-wxt1221 Bot-wxt1221 changed the title turn-rs: init at 3.0.0 turn-rs: init at 3.0.1 Sep 11, 2024
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review September 11, 2024 02:52
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4560

@Bot-wxt1221 Bot-wxt1221 removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Sep 11, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Sep 11, 2024
SuperSandro2000
SuperSandro2000 reviewed Sep 13, 2024
View reviewed changes
nixos/modules/services/misc/turn-rs.nix Outdated
settings = lib.mkOption {
type = lib.types.str;
description = "Turn-rs server config file";
default = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a proper submodule type. Right now you probably need to repeat half of the default text which is not great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean NixOS/rfcs#42?

pkgs/by-name/tu/turn-rs/package.nix Outdated Show resolved Hide resolved
@nyabinary
Copy link
Contributor

Should probably wait for 3.1.0 (and update the module options if needed as well)
mycrl/turn-rs#96

@nyabinary
Copy link
Contributor

Should probably wait for 3.1.0 (and update the module options if needed as well) mycrl/turn-rs#96

3.1.0 released
https://github.com/mycrl/turn-rs/releases/tag/v3.1.0

nbraud
nbraud reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aside from the RFC42 concerns.

Feel free to let us know if you would need help doing that.

@h7x4
Copy link
Member

h7x4 commented Sep 18, 2024

Here's a patch containing the freeform module fixes, in addition to some secret handling stuff and a nixos test: https://gist.github.com/h7x4/c3a2365d4ed3e84686b3198aa4a03efe

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Sep 18, 2024 •
edited
Loading

@h7x4 Thanks for advicing. I will approval your patch.

@Bot-wxt1221 Bot-wxt1221 changed the title turn-rs: init at 3.0.1 turn-rs: init at 3.1.0 Sep 18, 2024
@h7x4 h7x4 added the 8.has: tests This PR has tests label Sep 18, 2024
h7x4
h7x4 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but half of the code is now coming from my patch so someone else should probably have a look too :)

h7x4
h7x4 reviewed Sep 18, 2024
View reviewed changes
nixos/tests/turn-rs.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/turn-rs.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 97ca40d into NixOS:master Sep 19, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@nbraud nbraud nbraud left review comments

@kirillrdy kirillrdy kirillrdy left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: turn-rs
7 participants
@Bot-wxt1221 @nyabinary @nixos-discourse @h7x4 @kirillrdy @nbraud @SuperSandro2000