Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/services.mpd: remove with lib; #339100

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Sep 2, 2024

Description of changes

part of #208242

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script went pretty far off the rails here Felix @Stunkymonkey

nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
nixos/modules/services/audio/mpd.nix Outdated Show resolved Hide resolved
@Stunkymonkey Stunkymonkey merged commit 3884721 into NixOS:master Sep 11, 2024
24 checks passed
@Stunkymonkey Stunkymonkey deleted the mpd-remove-with-lib branch September 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants