ci/nixpkgs-vet: 0.1.2 -> 0.1.4 #339119
ci/nixpkgs-vet: 0.1.2 -> 0.1.4 #339119
Conversation
philiptaron
force-pushed
the
nixpkgs-vet
branch
from
258e58e
to
d58c2a4
Compare
There was a problem hiding this comment.
As discussed in PMs, probably best not to add pkgs.nixpkgs-vet:
- It would be confusing because it's not the actual version of the tool that should be used to check CI. Instead
./maintainers/scripts/nixpkgs-vet.shshould be used, which fetches the correct version (though it also needs to build it) - CI won't be able to use the version from Nixpkgs, nor reuse its Hydra build results
- We'd be duplicating the Nix expression here, they could easily drift apart (and indeed did already here!)
- Nixpkgs-vet should be considered downstream from Nixpkgs. With the automated weekly update action we have in the Nixpkgs-vet repo, we'll be notified if any dependency breaks the build. I don't think there's a need for package maintainers to try to prevent build failures in Nixpkgs already.
- It's also just less confusing, less recursive references :)
Adding libSrc for the other purposes sounds fine though
Other than that and the couple comments, I think this looks good!
philiptaron
force-pushed
the
nixpkgs-vet
branch
from
d58c2a4
to
9bece8f
Compare
|
Dropped commits making |
|
Ohh, we should totally move |
I don't see any reason to make a new symlink in |
|
Sounds good to me! |
philiptaron
force-pushed
the
nixpkgs-vet
branch
2 times, most recently
from
f12a88b
to
2f3c8b0
Compare
philiptaron
force-pushed
the
nixpkgs-vet
branch
from
2f3c8b0
to
841d873
Compare
Everything gets moved into the `ci/` top-level directory. We keep behind `maintainers/scripts/check-by-name.sh` and `pkgs/test/check-by-name/pinned-version.txt` as they are going to cause CI errors and confusion until we get all the way through the various channels. They'll be removed in about a week or so.
philiptaron
force-pushed
the
nixpkgs-vet
branch
from
841d873
to
89cbfde
Compare
|
OK, I finished futzing with |
|
Should we backport this to 24.05? I think we should. |
| # | ||
| # When you make changes to this workflow, also update pkgs/test/check-by-name/run-local.sh adequately | ||
| # Checks pkgs/by-name (see pkgs/by-name/README.md) using the `nixpkgs-vet` tool (see https://github.com/NixOS/nixpkgs-vet) | ||
| # When you make changes to this workflow, please also update `ci/nixpkgs-vet.sh` to reflect the impact of your work to the CI. | ||
| name: Check pkgs/by-name |
There was a problem hiding this comment.
Oh just noticed that this would also be good to change
|
I don't think we need to bother backporting, because anything that only goes to release branches won't affect Nixpkgs long-term |
|
I guess it might be confusing if different checks are enforced for different PRs though |
Motivation for change
nixpkgs-vetnixpkgs-vet#100The
nixpkgs-check-by-nametool is expanding its scope to vet more changes across Nixpkgs.Description of changes
nixpkgs-check-by-nametonixpkgs-vet.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)