Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.lze: init at 0.1.1 #339387

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

BirdeeHub
Copy link
Contributor

@BirdeeHub BirdeeHub commented Sep 4, 2024

I made this, and I almost completely deleted it because I was fully on board with lz-n again. However, I have been using it and lz-n simultaneosly and trying them out.

I wish to publish lze after all. I like it a lot.

It works completely differently from lz-n and has a different handler api, but has a similar plugin spec.

It has been rewritten significantly AGAIN since I last went to upload it.

It has a much more respectful readme this time around too, as now I have more legitimately good things to say about both options.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 4, 2024
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though nixpkgs-review would be nice

CC @mrcjkb @teto

@mrcjkb
Copy link
Member

mrcjkb commented Sep 11, 2024

Result of nixpkgs-review pr 339387 run on x86_64-linux 1

7 packages built:
  • lua51Packages.lze
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BirdeeHub fyi, you can run nixpkgs-review with nix run .#nixpkgs-review -- pr <pr-number> --post (replace <pr-number>, in this case with 339387).
I've just run it for x86_64-linux.

See also: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#tested-compilation-of-all-pkgs-that-depend-on-this-change-using-nixpkgs-review

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 11, 2024
@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Sep 11, 2024

Ah, yeah ty. Still new here. Kinda thought that other people were supposed to be the ones to run it to make sure it worked on THEIR hardware. Some stuff still to learn about contributing :)

@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Sep 11, 2024

I also forgot about the --post option XD My PAT doesnt have permissions to post :( Guess I have to change that

@BirdeeHub
Copy link
Contributor Author

Result of nixpkgs-review pr 339387 run on x86_64-linux 1

7 packages built:
  • lua51Packages.lze
  • luaPackages.lze (lua52Packages.lze)
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

@PerchunPak
Copy link
Member

Ah, yeah ty. Still new here. Kinda thought that other people were supposed to be the ones to run it to make sure it worked on THEIR hardware. Some stuff still to learn about contributing :)

(Still new here as well) I suppose simple packages, that don't use any specific hardware (cuda, drivers, etc), don't need to be tested by external contributor as Nix is pure and if something works on one system, it will work everywhere

@BirdeeHub
Copy link
Contributor Author

Yeah Id be pretty surprised if this didnt work anywhere that you could run nvim XD I dont even refer to any filepaths anywhere XD

I made this, and I almost completely deleted it because I was fully
on board with lz-n again. However, I have been using it and lz-n
simultaneosly and trying them out.

I wish to publish lze after all. I like it a lot.

It works completely differently from lz-n and has a different handler
api, but has a similar plugin spec.

Update pkgs/development/lua-modules/overrides.nix

Co-authored-by: Gaétan Lepage <[email protected]>
@PerchunPak
Copy link
Member

I also forgot about the --post option XD My PAT doesnt have permissions to post :( Guess I have to change that

Btw, you don't have to use --post. For example, I am too lazy to configure my GitHub key, so I just do cat report.md in a shell created by nixpkgs-review

@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 14, 2024
@BirdeeHub
Copy link
Contributor Author

Thats fair. It was easy enough tho :)

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339387 run on aarch64-darwin 1

7 packages built:
  • lua51Packages.lze
  • lua52Packages.lze
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339387 run on x86_64-darwin 1

7 packages built:
  • lua51Packages.lze
  • lua52Packages.lze
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339387 run on x86_64-linux 1

7 packages built:
  • lua51Packages.lze
  • lua52Packages.lze
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 339387 run on aarch64-linux 1

7 packages built:
  • lua51Packages.lze
  • lua52Packages.lze
  • lua53Packages.lze
  • lua54Packages.lze
  • luajitPackages.lze
  • vimPlugins.lze
  • vimPluginsUpdater

@GaetanLepage GaetanLepage merged commit c6e077b into NixOS:master Sep 14, 2024
25 of 26 checks passed
@BirdeeHub BirdeeHub deleted the vimPlugins.lze branch September 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lua 6.topic: vim 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants