-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.lze: init at 0.1.1 #339387
vimPlugins.lze: init at 0.1.1 #339387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of 7 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@BirdeeHub fyi, you can run nixpkgs-review with nix run .#nixpkgs-review -- pr <pr-number> --post
(replace <pr-number>
, in this case with 339387
).
I've just run it for x86_64-linux.
Ah, yeah ty. Still new here. Kinda thought that other people were supposed to be the ones to run it to make sure it worked on THEIR hardware. Some stuff still to learn about contributing :) |
I also forgot about the --post option XD My PAT doesnt have permissions to post :( Guess I have to change that |
Result of 7 packages built:
|
(Still new here as well) I suppose simple packages, that don't use any specific hardware (cuda, drivers, etc), don't need to be tested by external contributor as Nix is pure and if something works on one system, it will work everywhere |
Yeah Id be pretty surprised if this didnt work anywhere that you could run nvim XD I dont even refer to any filepaths anywhere XD |
I made this, and I almost completely deleted it because I was fully on board with lz-n again. However, I have been using it and lz-n simultaneosly and trying them out. I wish to publish lze after all. I like it a lot. It works completely differently from lz-n and has a different handler api, but has a similar plugin spec. Update pkgs/development/lua-modules/overrides.nix Co-authored-by: Gaétan Lepage <[email protected]>
daac77a
to
6b1aa61
Compare
Btw, you don't have to use --post. For example, I am too lazy to configure my GitHub key, so I just do |
Thats fair. It was easy enough tho :) |
Result of 7 packages built:
|
Result of 7 packages built:
|
Result of 7 packages built:
|
Result of 7 packages built:
|
I made this, and I almost completely deleted it because I was fully on board with lz-n again. However, I have been using it and lz-n simultaneosly and trying them out.
I wish to publish lze after all. I like it a lot.
It works completely differently from lz-n and has a different handler api, but has a similar plugin spec.
It has been rewritten significantly AGAIN since I last went to upload it.
It has a much more respectful readme this time around too, as now I have more legitimately good things to say about both options.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.