Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuget-to-nix: comply with RFC 0166 when generating .nix files #339842

Closed
wants to merge 1 commit into from

Conversation

Scrumplex
Copy link
Member

Description of changes

This changed nuget-to-nix to generate .nix files that comply with RFC 0166.

Brought up in #339630

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Sep 5, 2024
@corngood
Copy link
Contributor

corngood commented Sep 5, 2024

I'd say this is a duplicate of #325053. There are various problems with doing it this way.

I think the consensus was just to ignore nixfmt on these files for now.

@Scrumplex
Copy link
Member Author

I see.

@Scrumplex Scrumplex closed this Sep 5, 2024
@Scrumplex Scrumplex deleted the pkgs/nuget-to-nix/nixfmt branch September 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: dotnet Language: .NET
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants