Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/importNpmLock: general improvements #340019

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Sep 6, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki requested review from philiptaron and removed request for winterqt September 6, 2024 08:19
@hsjobeki hsjobeki requested a review from a team September 6, 2024 08:19
@hsjobeki hsjobeki force-pushed the doc/importNpmLock branch 2 times, most recently from 2fc69c6 to 9092f5d Compare September 6, 2024 08:45
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
@hsjobeki
Copy link
Contributor Author

hsjobeki commented Sep 6, 2024

@fricklerhandwerk Thank you for the review. 👍 I worked most of your suggestions into it now.

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/javascript.section.md Outdated Show resolved Hide resolved
@fricklerhandwerk fricklerhandwerk merged commit 71f01ce into NixOS:master Sep 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants