Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rust: Improve wording about adding Cargo.lock to src #340287

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

djacu
Copy link
Member

@djacu djacu commented Sep 7, 2024

Description of changes

Improved the wording about adding the Cargo.lock file to src. It was not clear when this operation was necessary.

Things done

Only changed Rust docs.


Add a 👍 reaction to pull requests you find important.

Improved the wording about adding the Cargo.lock file to src. It was not
clear when this operation was necessary.
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes it clearer IMHO.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 7, 2024
@a-kenji a-kenji requested a review from jopejoe1 November 6, 2024 23:12
@jopejoe1 jopejoe1 merged commit b0fecba into NixOS:master Nov 6, 2024
27 checks passed
@djacu djacu deleted the rust/improve-lock-symlink-wording branch November 7, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: rust 8.has: documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants