-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switchres: init at 2.2.1 #340709
switchres: init at 2.2.1 #340709
Conversation
bcba05e
to
a9d7ac4
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4547 |
a9d7ac4
to
d06d3e6
Compare
Result of 1 package built:
|
Tried to run this on my system and it's not working to actually set the generated modelines to an output: [nix-shell:~]$ sudo switchres 320 240 60 -i /home/damian/Emulation/test/switchres.ini
[sudo] password for damian:
Switchres(v2.2.1) add display[0]
Switchres: display[0] options: monitor[generic_15] generation[on]
Switchres: Monitor range 15625.00-15750.00,49.50-65.00,2.000,4.700,8.000,0.064,0.192,1.024,0,0,192,288,448,576
Switchres: Calculating best video mode for [email protected] orientation: normal
Switchres: could not find a video mode that meets your specs Things I tried:
Manually adding the generated modeline from this: [nix-shell:~]$ switchres 320 240 60 -i /home/damian/Emulation/test/switchres.ini -c
Switchres(v2.2.1) add display[0]
Switchres: display[0] options: monitor[generic_15] generation[on]
Switchres: Monitor range 15625.00-15750.00,49.50-65.00,2.000,4.700,8.000,0.064,0.192,1.024,0,0,192,288,448,576
Switchres: Calculating best video mode for [email protected] orientation: normal
Switchres: ( 0)x( 0)_(0=0.000000Hz)
rng(0): 320 x 240_60.000000p 15.660000 [integ] scale(1.000, 1.000, 1.000) diff(0.000, 0.000, 0.000)
Switchres: normal ([email protected])->([email protected])
rng(0): 320 x 240_60.000000p 15.660000 [integ] scale(1.000, 1.000, 1.000) diff(0.000, 0.000, 0.000)
Switchres: Modeline "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync
Switchres: success adding mode dummy timing "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync
Switchres: success deleting mode dummy timing "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync ...with xrandr and setting the screen to it does work so I don't necessarily think it's a hardware fault or the kernel patch fault. When switchres is building these lines come up which might be the reason:
|
d06d3e6
to
754161a
Compare
@damiankorcz Try again with this. |
@Bot-wxt1221
It erroring out on the ports from the Nvidia card makes sense since they aren't supposed to work with this but the |
@damiankorcz [ERROR] missing X11_LIBRARY library So the prebuilt work? https://github.com/antonioginer/switchres/releases/tag/v2.2.1 |
@Bot-wxt1221 Not sure why it's complaining about X11. I'm booted up into KDE 6 with X11. But to does seem to building ok now. Here is the full build log:
Could it be with how I'm running it? Sorry I'm fairly new to NixOS so still figuring some of these things out 😅 |
I've found mentions of the following packages:
Potentially those missing are causing the X11 issue. Sources (both from the same individual on different platforms):
More context as to why it might be required to have the development packages included: |
@damiankorcz It is caused by the runtime library dependencies. I will patch the path later. |
754161a
to
e2b1fdc
Compare
Jackpot 🥳 18ae1036-053d-4120-a123-3d0616cc02bb.mp4All seems to be working as intended now. Awesome job! Thank you @Bot-wxt1221
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1946 |
@damiankorcz Could you approval this PR? |
Result of 1 package built:
|
LGTM. Works as intended. |
We should wait for an nixpkgs committer anyway. |
e2b1fdc
to
dbd569f
Compare
Result of 1 package built:
|
Description of changes
fix #340668
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.