Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.generators.toINI: allow lists of name-value pairs as section contents #340726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thecaralice
Copy link
Contributor

Description of changes

Some sofware depends on the order of elements inside a section. For example, aerc needs the filters section
to be ordered from the most to least specific (aerc-config(5)).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

…ents

Some sofware depends on the order of elements inside a section.
For example, [aerc] needs the `filters` section
to be ordered from the most to least specific ([`aerc-config(5)`][aerc-config-filters]).

[aerc]: https://aerc-mail.org
[aerc-config-filters]: https://git.sr.ht/~rjarry/aerc/tree/master/item/doc/aerc-config.5.scd#L954
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Sep 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant