Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gancio service fixes #340782

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Gancio service fixes #340782

merged 3 commits into from
Sep 10, 2024

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Sep 9, 2024 •
edited
Loading

  1. fix ssl by default (mkDefault was not enough to override default values)
  2. use socket between nginx and gancio
  3. add back default value for baseurl (I missed that it was removed when moved into settings)

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 9, 2024
@jbgi
Copy link
Contributor Author

jbgi commented Sep 9, 2024

@ofborg test gancio

@jbgi jbgi force-pushed the gancio-fixes branch 2 times, most recently from b891d94 to 58cfe6f Compare September 9, 2024 13:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Sep 9, 2024
@jbgi
Copy link
Contributor Author

jbgi commented Sep 9, 2024

@ofborg test gancio

h7x4
h7x4 reviewed Sep 10, 2024
View reviewed changes
nixos/modules/services/web-apps/gancio.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gancio.nix Show resolved Hide resolved
nixos/modules/services/web-apps/gancio.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/gancio.nix Outdated Show resolved Hide resolved
@jbgi jbgi force-pushed the gancio-fixes branch 2 times, most recently from 990264a to 1c6416b Compare September 10, 2024 10:34
@jbgi
Copy link
Contributor Author

jbgi commented Sep 10, 2024

@ofborg test gancio

erictapen
erictapen reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except for one small thing. I'm glad you found a good solution for the socket permissions, I tried for a while to get nuxt to set the permissions of the socket and didn't manage to...

nixos/modules/services/web-apps/gancio.nix Outdated Show resolved Hide resolved
erictapen
erictapen approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you have anything to add, @h7x4 ? Otherwise I'd merge this.

@h7x4
Copy link
Member

h7x4 commented Sep 10, 2024

Nope, go ahead :)

@erictapen erictapen merged commit 5a39b9e into NixOS:master Sep 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 approved these changes

@erictapen erictapen erictapen approved these changes

@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbgi @h7x4 @erictapen