Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtlamr: init at 0.9.3-unstable-2023-08-13 #340833

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

JMendyk
Copy link

@JMendyk JMendyk commented Sep 9, 2024

Description of changes

The rtlamr is an rtl-sdr receiver for Itron ERT compatible smart meters operating in the 900MHz ISM band. The project is hosted at https://github.com/bemasher/rtlamr.

Tested with rtl_tcp (from rtl-sdr package) which provides data that rtlamr processes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 9, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 9, 2024
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
@Bot-wxt1221
Copy link
Member

Welcome to nixpkgs anyway.

pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/rt/rtlamr/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself to maintainer list.

@JMendyk
Copy link
Author

JMendyk commented Sep 11, 2024

Add yourself to maintainer list.

I added the definition in maintainer-list.nix and included myself in package's meta.maintainers. Is there an additional place that I missed?

@Bot-wxt1221
Copy link
Member

@JMendyk Nothing.

Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please reword the second commit message to rtlamr: init at 0.9.3-unstable-2023-08-13

@JMendyk JMendyk changed the title rtlamr: init at 2023-08-13 rtlamr: init at 0.9.3-unstable-2023-08-13 Sep 11, 2024
@JMendyk
Copy link
Author

JMendyk commented Sep 11, 2024

@Aleksanaa Updated the commit message and PR name. I assume that now I should wait for the PR to get merged (as the nixpkgs-review merge is not available for me yet)?

@Aleksanaa Aleksanaa merged commit c8daa7e into NixOS:master Sep 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants