Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: fix nixos-rebuild-specialisations test #341029

Merged
merged 1 commit into from
Sep 10, 2024
Merged

nixos/tests: fix nixos-rebuild-specialisations test #341029

merged 1 commit into from
Sep 10, 2024

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Sep 10, 2024

Description of changes

See https://hydra.nixos.org/build/272096143

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Sep 10, 2024
@r-vdp r-vdp requested review from K900 and vcunat September 10, 2024 14:55
@r-vdp r-vdp added the 1.severity: channel blocker Blocks a channel label Sep 10, 2024
@vcunat vcunat mentioned this pull request Sep 10, 2024
Merged
13 tasks
@emilazy emilazy merged commit 5ed6275 into NixOS:master Sep 10, 2024
10 of 11 checks passed
@r-vdp r-vdp deleted the fix-specialisation-test branch September 10, 2024 15:01
@K900
Copy link
Contributor

K900 commented Sep 10, 2024

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@K900 K900 Awaiting requested review from K900

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-vdp @K900 @SuperSandro2000 @emilazy