Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playerctl: enable zsh completions #341057

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

anund
Copy link
Contributor

@anund anund commented Sep 10, 2024

Description of changes

Enable zsh completions available upstream

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex
Copy link
Member

Result of nixpkgs-review pr 341057 run on x86_64-linux 1

8 packages built:
  • CuboCore.coretoppings
  • gtklock-playerctl-module
  • i3lock-pixeled
  • nwg-panel
  • nwg-panel.dist
  • playerctl
  • waybar
  • yabar-unstable

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

$ tree results/playerctl/
results/playerctl/
├── bin
│   ├── playerctl
│   └── playerctld
├── include
│   └── playerctl
│       ├── playerctl-enum-types.h
│       ├── playerctl.h
│       ├── playerctl-player.h
│       ├── playerctl-player-manager.h
│       ├── playerctl-player-name.h
│       └── playerctl-version.h
├── lib
│   ├── girepository-1.0
│   │   └── Playerctl-2.0.typelib
│   ├── libplayerctl.so -> libplayerctl.so.2
│   ├── libplayerctl.so.2 -> libplayerctl.so.2.4.1
│   ├── libplayerctl.so.2.4.1
│   └── pkgconfig
│       └── playerctl.pc
└── share
    ├── bash-completion
    │   └── completions
    │       └── playerctl.bash
    ├── dbus-1
    │   └── services
    │       └── org.mpris.MediaPlayer2.playerctld.service
    ├── gir-1.0
    │   └── Playerctl-2.0.gir
    ├── man
    │   └── man1
    │       └── playerctl.1.gz
    └── zsh
        └── site-functions
            └── _playerctl

17 directories, 18 files

@ofborg ofborg bot requested a review from puffnfresh September 10, 2024 17:58
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 10, 2024
@anund anund force-pushed the playerctl_enable_zsh_completion branch from c67b05e to 0097acf Compare September 11, 2024 18:58
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 12, 2024
@NickCao NickCao merged commit 366e429 into NixOS:master Sep 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants