modrinth-app-unwrapped: refactor and use pnpm hooks #341085
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pnpm_*.configHook
was added some time ago, and this package wasn't yet using it, so I refactored the package to use it.I also simplified the way it's decided which bundle to generate. I can revert this, if needed.
In another commit (that I will merge into the first one, if decided that it's an improvement) I made the package use
mkDerivation
combined withcargoSetupHook
, since that's the only functionality that the package was using anyway (because the build phase is overridden).This allowed getting rid of the
rec
added in the first commit.Note: the
theseus
repo has been renamed tocode
and combined into a monorepo. I didn't update therepo
offetchFromGitHub
yet, just wanted to share this.It seems that upstream is only keeping the tag for the latest version of the package in the
code
repo. Might need to ask them to start tagging properly.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.