steamvr: init #341095
steamvr: init #341095
Conversation
Pandapip1
force-pushed
the
init-steamvr
branch
from
4aa06c0
to
4164dcb
Compare
|
CC @Scrumplex |
Pandapip1
force-pushed
the
init-steamvr
branch
from
4164dcb
to
7a457ea
Compare
|
This is jaw dropping. I never even considered packaging Steam apps like this xD |
| fileList ? [ ], | ||
| fileListRegex ? false, | ||
| debug ? false, | ||
| hash ? lib.fakeHash, |
There was a problem hiding this comment.
| hash ? lib.fakeHash, | |
| hash ? "", |
This is more inline with fetchers like fetchCargoTarball and pnpm.fetchDeps
There was a problem hiding this comment.
I don't think the added complexity of doing it that way is particularly worth it. Those fetchers probably predate lib.fakeHash, so they chose the way that was simpler back then.
If you want to block on this, I'll change it, but I'd strongly prefer to keep it this way.
| }: | ||
|
|
||
| runCommand name | ||
| { |
There was a problem hiding this comment.
What does this accomplish?
EDIT: Figured it out. See #341095 (comment)
| outputHash = hash; | ||
| outputHashAlgo = "sha256"; | ||
| outputHashMode = "recursive"; | ||
| } |
There was a problem hiding this comment.
it also doesn't force a sha256 hash
| outputHash = hash; | |
| outputHashAlgo = "sha256"; | |
| outputHashMode = "recursive"; | |
| } | |
| outputHash = hash; | |
| outputHashMode = "recursive"; | |
| } | |
| // lib.optionalAttrs (hash == "") { outputHashAlgo = "sha256"; }) |
Pandapip1
force-pushed
the
init-steamvr
branch
from
26db564
to
1e0d81f
Compare
|
This looks pretty cool, but is there an advantage in using this over using SteamVR from the steam client? |
SteamVR inside Steam's fhsenv suffers from #217119, which means you won't be able to use asynchronous reprojection without bad workarounds. |
Ah, i see. thank your for explaining :) |
|
Additionally, this will allow other packages such as ALVR to depend on SteamVR. |
There was a problem hiding this comment.
This is quite amazing. Thanks a bunch.
I see two things that must to be done here:
- We need a written record of Valve approving us to package SteamVR using
patchelf. This doesn't need to be formal but some record we can point at to say "We're allowed to do this.". Precedent:nixpkgs/pkgs/applications/networking/instant-messengers/teamspeak/client.nix
Lines 123 to 156 in 1372130
- There needs to be documentation on the update procedure or, even better, an automatic updater.
|
Well, here's the conversation, for now: From: John, Gavin N. (Gavin) [email protected] Hi Valve VR folks, I'm Gavin, an incoming freshman at Caltech. In my free time, I like to package programs for nixpkgs, the package repository for the nix package manager and its NixOS linux distribution. I initially planned to package it by downloading it using depotdownloader, but discovered that SteamVR can't be downloaded in its entirety using anonymous accounts. This led me to discover the SteamVR licensing page, which had this email address. Would you be okay with me modifying and distributing my copy of SteamVR for the purpose of making it available to install through nixpkgs? Nixpkgs has a mechanism to keep track of licenses that users have agreed to, so installation of SteamVR can require agreement to the Steam Subscriber Agreement, the Steam PC Café Agreement, and/or the SteamVR Commercial Installation License. Thank you for your consideration! Sincerely, Gavin John From: Ben Jackson [email protected]
Thanks for bringing this to our attention. I have fixed that issue.
We would rather avoid that. I assume if depotdownloader works again, this would no longer be preferably anyway. --Ben From: John, Gavin N. (Gavin) [email protected] Hi Ben, Thank you for your response! Thanks for fixing the issue with depot downloader. That's going to help a lot. Some modifications to SteamVR will be necessary to make all functionality work with NixOS. Do I have permission to make a configuration file and script that makes the necessary modifications, and to have the config file and script distributed? Thank you! Sincerely, Gavin From: Ben Jackson [email protected] It's fine to distribute patches that apply after downloading the base content. If there are specific issues that you think are generic issues regarding portability you can also send them my way. |
|
I'm aware the packages I just added are missing some necessary things, such as formatting and Those packages will be necessary for the update script. |
Pandapip1
force-pushed
the
init-steamvr
branch
4 times, most recently
from
7786606
to
bea47b4
Compare
This reverts commit ff9ecc8.
Co-authored-by: seth <[email protected]>
Pandapip1
force-pushed
the
init-steamvr
branch
from
bea47b4
to
ec926fd
Compare
Description of changes
I have been given permission to package SteamVR by a Valve employee.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.