Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lighttpd: 1.4.75 -> 1.4.76 #341096

Merged
merged 1 commit into from
Sep 11, 2024
Merged

lighttpd: 1.4.75 -> 1.4.76 #341096

merged 1 commit into from
Sep 11, 2024

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Sep 10, 2024

Description of changes

The release tarball no longer comes with a ./configure script (related
to avoiding CVE-2024-3094 xz supply chain attack), so add autoreconfHook
to keep the build working.

https://www.lighttpd.net/2024/4/12/1.4.76/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bjornfor
Copy link
Contributor Author

When running nix-build -A lighttpd.tests I'm greeted with this error:

  Failed assertions:
  - Setting virtualisation.diskSize to `auto` is not supported by the current image build or vm runner; use an explicit size.

Is that due to 39df221? Did it break a lot of VM tests?

@bjornfor bjornfor force-pushed the update-lighttpd branch 3 times, most recently from 8b3a968 to b9e4ab0 Compare September 10, 2024 20:36
@bjornfor
Copy link
Contributor Author

Is that due to 39df221? Did it break a lot of VM tests?

Yes it did: #339535 (comment). And it's already reverted.

The release tarball no longer comes with a ./configure script (related
to avoiding CVE-2024-3094 xz supply chain attack), so add autoreconfHook
to keep the build working.

https://www.lighttpd.net/2024/4/12/1.4.76/
@bjornfor
Copy link
Contributor Author

Rebased on master to be able to run tests.

@ofborg ofborg bot requested a review from brechtcs September 11, 2024 00:11
@bjornfor bjornfor merged commit a65e693 into NixOS:master Sep 11, 2024
32 of 34 checks passed
@bjornfor bjornfor deleted the update-lighttpd branch September 11, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant