Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgee, libgda, zile: fix compiling with clang #341109

Merged
merged 1 commit into from
Sep 13, 2024
Merged

libgee, libgda, zile: fix compiling with clang #341109

merged 1 commit into from
Sep 13, 2024

Conversation

joshheinrichs-shopify
Copy link
Contributor

@joshheinrichs-shopify joshheinrichs-shopify commented Sep 10, 2024 •
edited
Loading

Description of changes

-Wno-incompatible-function-pointer-types was removed from vala's setup hook in b2d88d4. Without it, we're unable to compile libgee1, ligda and zile on Darwin. The libgda and zile failures were masked by libgee failing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Footnotes

  1. https://hydra.nixos.org/build/271035513 ↩

@joshheinrichs-shopify
libgee, libgda, zile: fix compiling with clang
77b1ada 
-Wno-incompatible-function-pointer-types was removed from vala's setup
hook in b2d88d4. Without it, we're unable to compile libgee[1], libgda,
and zile on Darwin. The libgda and zile failures were masked by libgee
failing.

[1]: https://hydra.nixos.org/build/271035513
@jtojnar
Copy link
Member

jtojnar commented Sep 11, 2024 •
edited
Loading

Is it possible it is using old generated C files from the tarball? Would autoreconfHook fix that?

Edit: Looks like at least libgda does use it so 😿

Edit: Ah, the file is not generated, we would need to backport https://gitlab.gnome.org/GNOME/libgda/-/commit/7abf8273674b42d9efc054f308c7e7a31120d03c

@joshheinrichs-shopify
Copy link
Contributor Author

joshheinrichs-shopify commented Sep 11, 2024 •
edited
Loading

Is it possible it is using old generated C files from the tarball? Would autoreconfHook fix that?

good question! i tried blindly applying this to libgee + zile too, but it didn't resolve the issue. seems like this is an open issue in vala? https://gitlab.gnome.org/GNOME/vala/-/issues/1413 ignoring the error seems to be the recommendation for now.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 13, 2024
@fabianhjr fabianhjr merged commit 1dbbe4e into NixOS:master Sep 13, 2024
29 of 31 checks passed
@trofi
Copy link
Contributor

trofi commented Sep 13, 2024 •
edited
Loading

This broke the eval on gcc-based systems. Proposed libgda fix as:

@barryfm
Copy link
Contributor

barryfm commented Sep 14, 2024

trofi: What about zile which needs the same change?

@trofi
Copy link
Contributor

trofi commented Sep 14, 2024

trofi: What about zile which needs the same change?

Great catch! Not sure how I missed it. Proposed the fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@fabianhjr fabianhjr fabianhjr approved these changes

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@pSub pSub Awaiting requested review from pSub

@bobby285271 bobby285271 Awaiting requested review from bobby285271

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joshheinrichs-shopify @jtojnar @trofi @barryfm @fabianhjr @AndersonTorres @wegank