lib/types: fix toCoerced's typeMerge #341112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes
lib.types.coercedTo
'stypeMerge
which previously (for 8 years!) took 2 arguments when it should only take 1.This didn't actually affect functionality as
coercedTo
cannot merge anyway but it results in an awful error message:error: value is a function while a set was expected
becausemergeOptionDecls
then thinks the types are actually mergeable (as the partially applied function is!= null
) leading to a worse error message down the line astype
is not an attrset.I've added a test (mainly as a reproducible example) but let me know if it's unnecessary/overkill.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.