tzdata: disable network access

[trofi]

Without the change tests fail on darwin as
https://hydra.nixos.org/build/272249259/nixlog/164/tail:

curl: (77) error setting certificate file: /no-cert-file.crt

Possibly because stdenv has curl there. Upstream suggests disabling networking access with CURL=:. Let's use that.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[gshpychka]

Build failed on aarch64-darwin - failed test for kyua:
error: builder for '/nix/store/62lizx9y3ra5zxppkwdj8jj97ryp8qy9-kyua-0.13-unstable-2024-01-22.drv' failed with exit code 1;

Failed one test:
utils/signals/timer_test:multiprogram_and_expire_before_activations -> failed: Line 296: exp_items != items ([2, 1, 3] != [1, 2, 3]) [2.199s]

Command: nix build github:NixOS/nixpkgs/pull/341307/merge#tzdata

build.log

[trofi]

I don't know much about kyua, but it does not look directly related. Is it a deterministic failure? If you try to build it a few times, dies it fail the same way?

[gshpychka]

I don't know much about kyua, but it does not look directly related. Is it a deterministic failure? If you try to build it a few times, dies it fail the same way?

My bad, seems like a flaky test. Rebuilding went well, but then failed with this:

error: derivation '/nix/store/idrifyhdkms6mxrwgqv489d37b1i0imh-tzdata-2024b.drv' may not be deterministic: output '/nix/store/iaxsrj1wvqz9hfw6362ci36xzzcdf3cm-tzdata-2024b-bin' differs

[emilazy]

That’s to be expected; we don’t have great reproducibility on Darwin right now.

[github-actions]

Successfully created backport PR for staging-24.05:

• [Backport staging-24.05] tzdata: disable network access #342975