vimPlugins.gina-vim: rename plugin to fix alias

[GaetanLepage]

Description of changes

The gina-vim plugin was marked as deprecated (rightfully so) but was not removed from vim-plugin-names.
This lead to an eval failure reported in #337444.

This PR properly removes renames the plugin.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[GaetanLepage]

Result of nixpkgs-review pr 341309 run on x86_64-linux 1

1 package built:

• vimPluginsUpdater

[PerchunPak]

Will take into consideration in #336137. Could you check also other deprecated plugins?

[teto]

gina recommends https://github.com/lambdalisue/vim-gin as an alternative. I dont think we package it and it is using deno, I am not sure how easy it's to add. Till then maybe we can keep gina. It might be deprecated but doesn't mean it's broken yet.

[GaetanLepage]

I think that the update script automatically added it to deprecated.json as the GH repo is marked as active.
It will behave the same the next times we will run it.

As the package has already been unavailable in nixpkgs for the past few months, I would argue that we properly deprecate it and eventually add gin.

[PerchunPak]

Oh, update script doesn't remove packages. It also doesn't check if repository archived. All it does is resolves redirects, and adds a notice about rename to deprecated.json

The reported error must come from another source (e.g. there is also an alias in aliases.nix

[PerchunPak]

Also, there are already multiple plugins that use denops.vim packaged (vim-pluto & ddc-vim). Packaging vim-gin won't be any problem

[GaetanLepage]

Oh, update script doesn't remove packages. It also doesn't check if repository archived. All it does is resolves redirects, and adds a notice about rename to deprecated.json

The reported error must come from another source (e.g. there is also an alias in aliases.nix

The plugin that was in the package set was gina-vim, but the alias was saying that this was the old name was vim-gina (which didn't exist).

I have simply ran the update script and propose that we merge this.

[GaetanLepage]

Result of nixpkgs-review pr 341309 run on x86_64-linux 1

6 packages marked as broken and skipped:

• lua52Packages.neotest
• lua53Packages.neotest
• lua54Packages.neotest
• lua54Packages.sqlite
• luajitPackages.neotest
• vimPlugins.sg-nvim

120 packages built:

• lua51Packages.neotest
• lua51Packages.sqlite
• lua52Packages.sqlite
• lua53Packages.sqlite
• luajitPackages.sqlite
• vimPlugins.ChatGPT-nvim
• vimPlugins.CopilotChat-nvim
• vimPlugins.SchemaStore-nvim
• vimPlugins.YouCompleteMe
• vimPlugins.advanced-git-search-nvim
• vimPlugins.aerial-nvim
• vimPlugins.auto-session
• vimPlugins.autosave-nvim
• vimPlugins.barbecue-nvim
• vimPlugins.cmake-tools-nvim
• vimPlugins.cmp-ai
• vimPlugins.cmp-clippy
• vimPlugins.cmp-fuzzy-buffer
• vimPlugins.cmp-fuzzy-path
• vimPlugins.cmp-git
• vimPlugins.cmp-npm
• vimPlugins.cmp-pandoc-nvim
• vimPlugins.cmp-tabnine
• vimPlugins.codeium-nvim
• vimPlugins.compiler-explorer-nvim
• vimPlugins.compiler-nvim
• vimPlugins.completion-treesitter
• vimPlugins.conform-nvim
• vimPlugins.copilot-lua
• vimPlugins.crates-nvim
• vimPlugins.csharpls-extended-lsp-nvim
• vimPlugins.cyberdream-nvim
• vimPlugins.ddc-source-lsp
• vimPlugins.diagram-nvim
• vimPlugins.diffview-nvim
• vimPlugins.fuzzy-nvim
• vimPlugins.gitlinker-nvim
• vimPlugins.gitsigns-nvim
• vimPlugins.go-nvim
• vimPlugins.hardhat-nvim
• vimPlugins.harpoon
• vimPlugins.harpoon2
• vimPlugins.haskell-scope-highlighting-nvim
• vimPlugins.himalaya-vim
• vimPlugins.idris2-nvim
• vimPlugins.image-nvim
• vimPlugins.lazy-lsp-nvim
• vimPlugins.lean-nvim
• vimPlugins.leap-ast-nvim
• vimPlugins.limelight-vim
• vimPlugins.lir-nvim
• vimPlugins.lspkind-nvim
• vimPlugins.mason-lspconfig-nvim
• vimPlugins.multicursors-nvim
• vimPlugins.neo-tree-nvim
• vimPlugins.neoconf-nvim
• vimPlugins.neogit
• vimPlugins.neorg
• vimPlugins.neotest
• vimPlugins.neotest-gradle
• vimPlugins.neotest-gtest
• vimPlugins.neotest-playwright
• vimPlugins.night-owl-nvim
• vimPlugins.nlsp-settings-nvim
• vimPlugins.none-ls-nvim
• vimPlugins.null-ls-nvim
• vimPlugins.nvim-coverage
• vimPlugins.nvim-lint
• vimPlugins.nvim-lspconfig
• vimPlugins.nvim-navbuddy
• vimPlugins.nvim-navic
• vimPlugins.nvim-spectre
• vimPlugins.nvim-treesitter
• vimPlugins.nvim-treesitter-parsers.gomod
• vimPlugins.nvim-treesitter-parsers.latex
• vimPlugins.nvim-treesitter-parsers.markdown
• vimPlugins.nvim-treesitter-parsers.markdown_inline
• vimPlugins.nvim-treesitter-parsers.perl
• vimPlugins.nvim-treesitter-parsers.scala
• vimPlugins.nvim-treesitter-parsers.sql
• vimPlugins.obsidian-nvim
• vimPlugins.octo-nvim
• vimPlugins.oil-nvim
• vimPlugins.ollama-nvim
• vimPlugins.orgmode
• vimPlugins.otter-nvim
• vimPlugins.overseer-nvim
• vimPlugins.persisted-nvim
• vimPlugins.playground
• vimPlugins.plenary-nvim
• vimPlugins.refactoring-nvim
• vimPlugins.render-markdown
• vimPlugins.rest-nvim
• vimPlugins.roslyn-nvim
• vimPlugins.smart-open-nvim
• vimPlugins.smart-splits-nvim
• vimPlugins.ssr
• vimPlugins.startup-nvim
• vimPlugins.supermaven-nvim
• vimPlugins.telescope-cheat-nvim
• vimPlugins.telescope-frecency-nvim
• vimPlugins.telescope-fzf-native-nvim
• vimPlugins.telescope-fzf-writer-nvim
• vimPlugins.telescope-fzy-native-nvim
• vimPlugins.telescope-media-files-nvim
• vimPlugins.telescope-nvim
• vimPlugins.telescope-symbols-nvim
• vimPlugins.telescope-undo-nvim
• vimPlugins.telescope-z-nvim
• vimPlugins.telescope-zoxide
• vimPlugins.todo-comments-nvim
• vimPlugins.typescript-tools-nvim
• vimPlugins.unison
• vimPlugins.vifm-vim
• vimPlugins.vim-gina
• vimPlugins.vim-tpipeline
• vimPlugins.vimtex
• vimPlugins.yazi-nvim
• vimPlugins.zarchive-vim-fsharp
• vimPluginsUpdater

[PerchunPak]

I have simply ran the update script and propose that we merge this.

Current update script is broken and doesn't do what I described, it is fixed in #336137. Though, for some reason, it correctly renamed the plugin

Also, let's not pollute commit history and change only parts that are related to this PR. And return deprecation please, it should work now

[GaetanLepage]

Current update script is broken and doesn't do what I described, it is fixed in #336137. Though, for some reason, it correctly renamed the plugin

Also, let's not pollute commit history and change only parts that are related to this PR. And return deprecation please, it should work now

You are right, let's do things properly.

Is there any remaining blocker on your PR ?

[GaetanLepage]

Result of nixpkgs-review pr 341309 run on x86_64-linux 1

2 packages built:

• vimPlugins.vim-gina
• vimPluginsUpdater

[PerchunPak]

Is there any remaining blocker on your PR ?

No, only review. I will also fix merge conflicts in a moment