follow: init at 0.0.1-alpha.13 #341356
Open
follow: init at 0.0.1-alpha.13 #341356
+113
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
|
Is it possible to build from source? |
Signed-off-by: iosmanthus <[email protected]>
iosmanthus
changed the title
|
@bobby285271 PTAL ❤️ |
Signed-off-by: iosmanthus <[email protected]>
Done |
Signed-off-by: iosmanthus <[email protected]>
NickCao
reviewed
Sep 19, 2024
pkgs/by-name/fo/follow/package.nix
Outdated
| pnpm, | ||
| stdenv, | ||
| }: | ||
| let |
There was a problem hiding this comment.
This is purely aesthetic, but we'd better just drop the let in block.
Comment on lines
+27
to
+32
| VITE_WEB_URL = "https://app.follow.is"; | ||
| VITE_API_URL = "https://api.follow.is"; | ||
| VITE_IMGPROXY_URL = "https://thumbor.follow.is"; | ||
| VITE_SENTRY_DSN = "https://e5bccf7428aa4e881ed5cb713fdff181@o4507542488023040.ingest.us.sentry.io/4507570439979008"; | ||
| VITE_BUILD_TYPE = "production"; | ||
| VITE_POSTHOG_KEY = "phc_EZGEvBt830JgBHTiwpHqJAEbWnbv63m5UpreojwEWNL"; |
There was a problem hiding this comment.
Please add a link pointing to where these magic variables are from.
There was a problem hiding this comment.
OK, these magic vars are copy from the upstream release workflow.
Signed-off-by: iosmanthus <[email protected]>
|
@NickCao comment addressed, PTAL. |
NickCao
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
pack https://github.com/RSSNext/Follow.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.