postgresql: improve fake pg_config in default output #341421
Open
+47
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
reviewed
Sep 15, 2024
To avoid the deprecation warning.
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
from
fcf27fe
to
cb6bbf2
Compare
Ma27
reviewed
Sep 17, 2024
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
from
cb6bbf2
to
d1da18d
Compare
Ma27
reviewed
Sep 17, 2024
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
from
d1da18d
to
9761c71
Compare
|
I'm not happy with the current implementation, yet. Two reasons:
|
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
from
9761c71
to
7783f3a
Compare
|
Ok, the latest version is one that I am quite happy with, it should check all the boxes. |
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
2 times, most recently
from
d67e3f2
to
09d6dc3
Compare
Except that the prevention of infinite recursion doesn't work as expected, yet. |
This fixes some build systems which look up the location of pg_config via the location of the postgres binary itself, e.g. timescaledb, instead of calling pg_config which is on PATH. Since the -dev output is correctly placed before the default output of postgresql in PATH, we can rely on that and call "pg_config" from the default output's fake script. Only do that, when the one on PATH is actually a different file, though, to prevent infinite loops. Resolves NixOS#341408
wolfgangwalther
force-pushed
the
postgresql-pg-config
branch
from
09d6dc3
to
0c47767
Compare
But now it does, after the latest push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes some build systems which look up the location of pg_config via the location of the postgres binary itself, e.g. timescaledb, instead of calling pg_config which is on PATH.
Since the -dev output is correctly placed before the default output of postgresql in PATH, we can rely on that and call "pg_config" from the default output's fake script. Only do that, when the one on PATH is actually a different file, though, to prevent infinite loops.
@Ma27 could you have a look?
Resolves #341408, CC @zoechi
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.