Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raze: wrap vulkan-loader #341672

Merged
merged 1 commit into from
Sep 14, 2024
Merged

raze: wrap vulkan-loader #341672

merged 1 commit into from
Sep 14, 2024

Conversation

qubitnano
Copy link
Contributor

Description of changes

Vulkan wasn't actually being used.

Before

GL_VENDOR: AMD
GL_RENDERER: AMD Radeon RX 5700 XT (radeonsi, navi10, LLVM 18.1.8, DRM 3.57, 6.10.8)
GL_VERSION: 4.6 (Core Profile) Mesa 24.2.1
GL_SHADING_LANGUAGE_VERSION: 4.60
GL Version parsed = 4.600000
GL_MAX_TEXTURE_SIZE: 16384

After

Vulkan device: AMD Radeon RX 5700 XT (RADV NAVI10)
Vulkan device type: discrete gpu
Vulkan version: 1.3.289 (api) 24.2.1 (driver)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 13, 2024
@Artturin Artturin merged commit 037b786 into NixOS:master Sep 14, 2024
28 of 30 checks passed
@qubitnano qubitnano deleted the raze branch September 14, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants