Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyphone: 2.3.0 -> 2.4.0 #341677

Merged
merged 1 commit into from
Sep 16, 2024
Merged

polyphone: 2.3.0 -> 2.4.0 #341677

merged 1 commit into from
Sep 16, 2024

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 13, 2024

Description of changes

Regular update + switch to Qt6 (with a workaround for #214765)
https://github.com/davy7125/polyphone/releases/tag/2.4.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from Maxdamantus September 13, 2024 23:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 13, 2024
@pbsbot
Copy link

pbsbot commented Sep 16, 2024

Result of nixpkgs-review pr 341677 run on x86_64-linux 1

1 package built:
  • polyphone

@pbsds
Copy link
Member

pbsds commented Sep 16, 2024

desktopfiles and such are still built 👍

@pbsds pbsds merged commit 8940542 into NixOS:master Sep 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants