Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-cloudwatch-agent: init at 1.300044.0 #341688

Closed

Conversation

philipmw
Copy link

@philipmw philipmw commented Sep 13, 2024

This commit also introduces a corresponding NixOS service module to manage the Amazon Cloudwatch Agent via systemd.

Based on
https://github.com/wearetechnative/amazon-cloudwatch-agent-nix/blob/main/module.nix

Description of changes

Amazon Cloudwatch Agent is an agent that collects data about the running server and sends metrics and logs to the Amazon Cloudwatch service.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

**Amazon CloudWatch Agent** is an agent that collects data about the running
server and sends metrics and logs to the *Amazon CloudWatch* service.

This commit also introduces a corresponding NixOS service module to manage the
Amazon CloudWatch Agent via systemd.

Based on
https://github.com/wearetechnative/amazon-cloudwatch-agent-nix/blob/main/module.nix
@commiterate
Copy link

I have an existing PR that's just pending a maintainer + review.

#337212

It skips start-amazon-cloudwatch-agent instead of trying to play nice with its hardcoded paths (its functionality can be extracted into 1-2 extra systemd unit settings).

@philipmw
Copy link
Author

I am closing this PR in favor of #337212

@philipmw philipmw closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants