doc/hooks/cernlib: document CERNLIB hook #341691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomodachi94
force-pushed
the
enhance/doc/hooks/cernlib
branch
from
4df9ad6
to
5caa597
Compare
|
@veprbl do you know if the environment variables set by this setup hook are documented anywhere? That is the chief reason this PR is a draft. |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
I don't think there is some deep meaning behind the variables, it's just how their build system was setup, and downstream applications did rely on those too. You can find descriptions in the table at https://cernlib.web.cern.ch/install/install.html . |
tomodachi94
force-pushed
the
enhance/doc/hooks/cernlib
branch
from
5caa597
to
513582c
Compare
|
I've gone ahead and added a link to the documentation for those variables for completeness' sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Attempt to document the setup hook included in the
cernlibpackage.I'm unsure of why this setup hook exists. I used GitHub search and found one non-Nixpkgs Makefile which uses the same variables the hook sets, but I can't find anything else. Input from @veprbl (the maintainer and creator of the setup hook) would be greatly appreciated.
Part of #341479.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.