Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.langchain*: Move dependencies of langchain-core to a common update script #342114

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Sep 15, 2024

Description of changes

Set all dependencies of langchain-core to use a common update script (that lists all of them) . Rationale: a core update tends to triger updates across the whole set. (This also provides guidance to anyone who updates langchain-core manually to check the rest of the set.)

Note: This shouldn't trigger any rebuilds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable: (n/a as there are no rebuilds)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec sarahec force-pushed the langchain-common-update branch 2 times, most recently from 6f1a597 to dffa0a2 Compare September 15, 2024 17:58
@sarahec sarahec requested a review from drupol September 15, 2024 18:00
@sarahec sarahec force-pushed the langchain-common-update branch 2 times, most recently from 847c20b to c14f150 Compare September 15, 2024 18:08
@sarahec sarahec mentioned this pull request Sep 15, 2024
13 tasks
@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 342114 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 15, 2024
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 15, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 17, 2024
@sarahec sarahec added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 18, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 18, 2024
@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 342114 run on x86_64-linux 1

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 342114 run on x86_64-darwin 1

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 342114 run on aarch64-darwin 1

@GaetanLepage
Copy link
Contributor

Result of nixpkgs-review pr 342114 run on aarch64-linux 1

@GaetanLepage GaetanLepage merged commit db1b2ed into NixOS:master Sep 20, 2024
21 checks passed
@sarahec sarahec deleted the langchain-common-update branch November 8, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants