Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onedrive: 2.5.0-rc3 -> 2.5.0 #342277

Merged
merged 1 commit into from
Sep 17, 2024
Merged

onedrive: 2.5.0-rc3 -> 2.5.0 #342277

merged 1 commit into from
Sep 17, 2024

Conversation

chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Sep 16, 2024 •
edited
Loading

Description of changes

https://github.com/abraunegg/onedrive/releases/tag/v2.5.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@chewblacka chewblacka marked this pull request as ready for review September 16, 2024 11:54
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 16, 2024
@MarcelCoding
Copy link
Member

Successfully tested using cherry-pick on stable.

@chewblacka chewblacka added the 8.has: package (update) This PR updates a package to a newer version label Sep 16, 2024
@chewblacka chewblacka added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 17, 2024
bertof
bertof approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@bertof bertof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@chewblacka chewblacka added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 17, 2024
@fabianhjr fabianhjr added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Sep 17, 2024
@fabianhjr fabianhjr merged commit 9cb21a4 into NixOS:master Sep 17, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertof bertof bertof approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chewblacka @MarcelCoding @AndersonTorres @bertof @fabianhjr