Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-desktop: 7.22.0 -> 7.24.1, signal-desktop-beta: 7.23.0-beta.1 -> 7.25.0-beta.2, signal-desktop(aarch64): 7.19.0 -> 7.23.0 #342308

Merged
merged 3 commits into from
Sep 18, 2024
Merged

signal-desktop: 7.22.0 -> 7.24.1, signal-desktop-beta: 7.23.0-beta.1 -> 7.25.0-beta.2, signal-desktop(aarch64): 7.19.0 -> 7.23.0 #342308

merged 3 commits into from
Sep 18, 2024

Conversation

teutat3s
Copy link
Member

@teutat3s teutat3s commented Sep 16, 2024 •
edited
Loading

Description of changes

signalapp/Signal-Desktop@v7.22.0...v7.24.1
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.25.0-beta.2
0mniteck/Signal-Desktop-Mobian@7.19.0...7.23.0

Closes: #338944

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s added the backport release-24.05 Backport PR automatically label Sep 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 16, 2024
@teutat3s teutat3s added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Sep 17, 2024
@emilazy emilazy merged commit ea97a4c into NixOS:master Sep 18, 2024
32 of 33 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Merged
1 task
@teutat3s teutat3s deleted the signal-desktop-7.24.1 branch October 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@urandom2 urandom2 Awaiting requested review from urandom2

@bkchr bkchr Awaiting requested review from bkchr

@equirosa equirosa Awaiting requested review from equirosa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teutat3s @emilazy