Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/services.cloudflared: fix filterConfig #342370

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

followup #335631

ping @caffineehacker

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 merged commit d82fa80 into NixOS:master Sep 16, 2024
9 of 10 checks passed
@caffineehacker
Copy link
Contributor

Thanks for the quick fix! I can confirm that my config evals correctly with this change.

@Stunkymonkey
Copy link
Contributor Author

sorry for even breaking your config. My bad... Sorry

@caffineehacker
Copy link
Contributor

No problem, it happens. That's why there are those of us who like to live dangerously on unstable :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants